How much effort did you put into your review? A glance, a quick reading, or an in-depth study?.If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?.Does this proposal fit well with the feel and direction of Swift?.Is the problem being addressed significant enough to warrant a change to Swift?.What is your evaluation of the proposal?.When writing your review, here are some questions you might want to answer in your review: The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. If you do email me directly, please put "SE-0351" somewhere in the subject line. All review feedback should be either on this forum thread or, if you would like to keep your feedback private, directly to the review manager. Reviews are an important part of the Swift evolution process. Please do your best to review each proposal on its own merits, while still understanding its relationship to the larger feature. Similarly, reviewers should hold back on in-depth discussion of a subject of an upcoming review. In particular, acceptance of one of the proposals should be considered provisional on future discussions of follow-on proposals that are closely related but have not yet completed the evolution review process. This proposal builds on the Regex type being reviewed simultaneously with this one, and is one of the proposed ways of creating such a type.Īs with the concurrency initiative last year, the core team acknowledges that reviewing a large number of interlinked proposals can be challenging. The proposal authors have put together a proposal overview with links to in-progress pitches and reviews.
This review is part of a collection of proposals for better string processing in Swift. The review of SE-0351: Regex Builder DSL begins now and runs through April 18, 2022.
0 kommentar(er)
